Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Realvu adapter: Remove _ps in _f=conf request #3995

Merged
merged 3 commits into from
Jul 23, 2019
Merged

Realvu adapter: Remove _ps in _f=conf request #3995

merged 3 commits into from
Jul 23, 2019
+41 −18

Conversation

tchibirev
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Remove _ps in _f=conf request, simplify modules/realvuAnalyticsAdapter.js

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
    it@realvu.com
  • official adapter submission

bretg
bretg requested changes Jul 22, 2019
View reviewed changes
Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking there should be a unit test update here to confirm that _ps is present when not expected.

@bretg bretg self-assigned this Jul 22, 2019
@bretg bretg changed the title Remove _ps in _f=conf request Realvu adapter: Remove _ps in _f=conf request Jul 23, 2019
bretg
bretg approved these changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@bretg bretg merged commit 0663a8a into prebid:master Jul 23, 2019
leonardlabat pushed a commit to criteo-forks/Prebid.js that referenced this pull request Jul 30, 2019
@tchibirev @leonardlabat
Realvu adapter: Remove _ps in _f=conf request (prebid#3995)
c7b1297 
* Remove _ps in _f=conf request

* Replace "

* realvuAnalyticsAdapter_spec updated
VideoReach pushed a commit to VideoReach/Prebid.js that referenced this pull request Aug 1, 2019
@tchibirev
Realvu adapter: Remove _ps in _f=conf request (prebid#3995)
ed78ba4 
* Remove _ps in _f=conf request

* Replace "

* realvuAnalyticsAdapter_spec updated
sa1omon pushed a commit to gamoshi/Prebid.js that referenced this pull request Nov 28, 2019
@tchibirev
Realvu adapter: Remove _ps in _f=conf request (prebid#3995)
59fdf0d 
* Remove _ps in _f=conf request

* Replace "

* realvuAnalyticsAdapter_spec updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretg bretg bretg approved these changes

Assignees

@bretg bretg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchibirev @bretg